Porting the card limits frontend to main branch #3174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespino
requested review from
wiggin77 and
chenilim
and removed request for
a team
|
@jespino FYI there are some webapp compile errors remaining. |
|
/update-branch |
* Fixing Issue 3124 * Update webapp/src/components/cardLimitNotification.tsx Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
* Shows "(Deleted User)" instead of UUID when user not found (mattermost-community#2354) (mattermost-community#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <wiggin77@warpmail.net> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <51395864+akkivasu@users.noreply.github.com> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * mattermost-communityGH-2212 - Update global link on board (mattermost-community#2492) (mattermost-community#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com> * mattermost-communityGH-2387 - Fixing link in comments (mattermost-community#2480) (mattermost-community#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com> * Addead feature to start product tour on using the welcome template (mattermost-community#2468) * Fixed a bug where images of the welcome board were not copied over. (mattermost-community#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * mattermost-communityGH-2496 - Updating board title truncation issue (mattermost-community#2497) (mattermost-community#2503) (cherry picked from commit f9cef8e) Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com> * set min-height on empty date to allow click (mattermost-community#2466) (mattermost-community#2504) (cherry picked from commit 20fe19a) Co-authored-by: Scott Bishel <scott.bishel@mattermost.com> * Fix problem with viewId 0 in the URL (mattermost-community#2474) (mattermost-community#2510) (cherry picked from commit 4cb3a0f) Co-authored-by: Jesús Espino <jespinog@gmail.com> * don't display temlate page if readonly and access revoked (mattermost-community#2499) (mattermost-community#2515) (cherry picked from commit 61f1a3c) Co-authored-by: Scott Bishel <scott.bishel@mattermost.com> * mattermost-communityGH-2447 - Updating label overflow (mattermost-community#2479) (mattermost-community#2517) * mattermost-communityGH-2447 - Updating label overflow * Updating labels css (cherry picked from commit 923437c) Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com> * mattermost-communityGh-2437 - Updating share board modal (mattermost-community#2511) (mattermost-community#2522) * mattermost-communityGh-2437 - Updating share board modal * Updating test * Updating card dialog and test * Updating comment list (cherry picked from commit 50ded69) Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com> * updated/synced prior PR (mattermost-community#2509) (mattermost-community#2523) * updated/synced prior PR * add title back for cypress tests * update unit test for cypress fix * move to function Co-authored-by: Mattermod <mattermod@users.noreply.github.com> (cherry picked from commit 5b309e8) Co-authored-by: Scott Bishel <scott.bishel@mattermost.com> * modify error page redirects (mattermost-community#2518) (mattermost-community#2532) (cherry picked from commit 84a3f8f) Co-authored-by: Doug Lauder <wiggin77@warpmail.net> * Dismiss tour from overlay (mattermost-community#2525) (mattermost-community#2531) * Shows "(Deleted User)" instead of UUID when user not found (mattermost-community#2354) (mattermost-community#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <wiggin77@warpmail.net> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <51395864+akkivasu@users.noreply.github.com> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * Added ability to dismiss tour from overlay * mattermost-communityGH-2212 - Update global link on board (mattermost-community#2492) (mattermost-community#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com> * mattermost-communityGH-2387 - Fixing link in comments (mattermost-community#2480) (mattermost-community#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com> * Addead feature to start product tour on using the welcome template (mattermost-community#2468) * Fixed a bug where images of the welcome board were not copied over. (mattermost-community#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * Fixed intended behavio * lint fixes * Fixed tests * Fixed tests Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Akshay Vasudeva Rao <51395864+akkivasu@users.noreply.github.com> Co-authored-by: Winson Wu <93531870+wuwinson@users.noreply.github.com> Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com> (cherry picked from commit a53e947) Co-authored-by: Harshil Sharma <18575143+harshilsharma63@users.noreply.github.com> * Updated Mac what's new for v0.15 * Done with the frontend for limited card count * Updated the code and done with the unit test case * Updated the code according to the review comment and fixed the test cases and ES lints issue * Fixed the import for css file * Changes made according to review comments, Reverted back whatsnew.txt * Minor changes * Updated the code considering review comments Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Akshay Vasudeva Rao <51395864+akkivasu@users.noreply.github.com> Co-authored-by: Winson Wu <93531870+wuwinson@users.noreply.github.com> Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com> Co-authored-by: Harshil Sharma <18575143+harshilsharma63@users.noreply.github.com> Co-authored-by: Scott Bishel <scott.bishel@mattermost.com> Co-authored-by: Jesús Espino <jespinog@gmail.com> Co-authored-by: Doug Lauder <wiggin77@warpmail.net> Co-authored-by: Chen-I Lim <chenilim@gmail.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
jespino
force-pushed
the
port-card-limits
branch
from
7ca5e42 to
edbe7d2
Compare
jespino
added
2: Dev Review
|
@wiggin77 this should be ready now |
|
@jespino , it looks like there is an empty file added: webapp/src/components/cardLimitNotification.scss |
wiggin77
approved these changes
Jun 20, 2022
|
@wiggin77 done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.