Move teamless data migration with the rest of data migrations and update teamless boards query #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgdelacroix
force-pushed
the
fix-teamless-data-migration
branch
from
4313467 to
4bad1ef
Compare
|
Can you separate the fix and the movement in two different commits, this is going to be really hard to review if not. |
mgdelacroix
force-pushed
the
fix-teamless-data-migration
branch
from
4bad1ef to
5c5a2bb
Compare
|
@jespino done! |
sbishel
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The teamless boards data migration was relying on boards of type
DandG, that were removed as part of #2928. This PR reverts said patch, fixes the query that fetches teamless boards and cleans a bit the data migration code, moving the migration itself to thedata_migrations.gofile and ensuring migration and schema version keys are consistently named and placed.The actual fix for the teamless data migration in MySQL is 5c5a2bb
Ticket Link
Fixes #2941