Skip to content

Conversation

chenilim
Copy link
Contributor

Summary

Added local (Personal Server) version of permissions_test.

  • Added missing permission check for duplicating board to another team
  • Refactored permissions_test to handle variable user IDs (for local server tests)

Diff permissinos_tests.go with local_permissions_tests.go to see differences in expected responses.

@chenilim chenilim requested a review from a team as a code owner April 18, 2022 23:14
@chenilim chenilim requested review from jespino and Rajat-Dabade and removed request for a team April 18, 2022 23:14
testData := setupData(t, th)

ttCases := []TestCase{
{"/register", methodPost, "", userAnon, http.StatusInternalServerError, 0},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why register method is generating an InternalServerError?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've updated the test case to make a successful register call.

Copy link
Contributor

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, except the InternalServerError return on register.

@chenilim chenilim requested a review from jespino April 19, 2022 16:53
Copy link
Contributor

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenilim chenilim merged commit 3c7fd72 into mattermost-community:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants