Various UI updates on permissions #2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaadmahmood
requested review from
Pinjasaur and
Rajat-Dabade
and removed request for
a team
Pinjasaur
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
LGTM. Non-blocking question: I noticed a few different opacity values that feel a bit like "magic numbers"—would it be worth making them variables or maybe multiples of some base amount? Not familiar enough to know if there's some larger pattern like that e.g. design system or not.
|
@Pinjasaur We use a 4/8px grid system for the opacities. That's how we do it in the webapp too. We previously had all the colors defined as variables (in the webapp), but we shifted to this approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Various UI updates on permissions
Screenshots