gh-2591 Fix cypress tests #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbishel
requested review from
wiggin77 and
harshilsharma63
and removed request for
a team
|
/update-branch |
|
woohoo - The cypress tests passed.... |
|
Merging because cypress tests are passing. Test failures are in server tests. |
wiggin77
reviewed
Mar 24, 2022
| if userID == "" || teamID == "" || permission == nil { | ||
| return false | ||
| } | ||
| // Locally there is no team, so return true |
There was a problem hiding this comment.
@sbishel this change breaks server unit tests. See https://community.mattermost.com/core/pl/qym96zhiopro3px6es7axg9f1w
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes localpermissions to return 'true' for team permission check.
Fixes other cypress test issues where template form was being used
Ticket Link
#2591