fixes for shared boards #2581
fixes for shared boards #2581
Conversation
sbishel
requested review from
harshilsharma63,
chenilim and
jespino
and removed request for
a team and
chenilim
|
I discovered when running locally, you need to make sure to build the webapp and server before building the plugin. Locally, the I updated my test server to this PR. You can test it out here - |
| } | ||
| }, [teamId, match.params.boardId, match.params.viewId]) | ||
| }, [teamId, match.params.boardId, match.params.viewId, me]) |
There was a problem hiding this comment.
nit: probably a super tiny optimization is to pass use the me?.id as dependency, that way your user changes doesn't necesarilly retrigger this effect.
webapp/src/router.tsx
Outdated
| @@ -159,9 +159,13 @@ const FocalboardRouter = (props: Props): JSX.Element => { | |||
| <ChangePasswordPage/> | |||
| </FBRoute>} | |||
|
|
|||
| <FBRoute path='/shared/:boardId?/:viewId?/:cardId?'> | |||
| <FBRoute path='/workspace/:workspaceId/shared/:boardId?/:viewId?/:cardId?'> | |||
There was a problem hiding this comment.
This is here for backward compatibility, I guess, do we need the previous one (without the team or workspace) URL too?
There was a problem hiding this comment.
Also, you can use an array of paths in the path attribute, so probably makes sense to pass the array of all the valid urls that are for shared boards in one single route.
There was a problem hiding this comment.
Also, some routes later, we have a redirect from /workspace/:workspaceId/shared/:boardId?/:viewId?/:cardId? for this specific case, so we should fix that there, I guess.
|
/update-branch |
|
/update-branch |
|
/update-branch |
|
/update-branch |
Summary
Updates necessary for Shared Boards to work with permission changes.
Ticket Link
Fixes #2502