Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss tour from overlay #2525

Merged
merged 14 commits into from
Mar 11, 2022
Merged

Dismiss tour from overlay #2525

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
fd2d215
Shows "(Deleted User)" instead of UUID when user not found (#2354) (#…
mattermost-build Mar 4, 2022
5a1dc1c
Update CHANGELOG.md for v0.15
wuwinson Mar 4, 2022
725d7d6
Added ability to dismiss tour from overlay
harshilsharma63 Mar 8, 2022
79a8e99
GH-2212 - Update global link on board (#2492) (#2495)
mattermost-build Mar 8, 2022
813c459
GH-2387 - Fixing link in comments (#2480) (#2498)
mattermost-build Mar 9, 2022
32abd99
Addead feature to start product tour on using the welcome template (#…
harshilsharma63 Mar 8, 2022
679cf82
Fixed a bug where images of the welcome board were not copied over. (…
harshilsharma63 Mar 8, 2022
581e688
Merge branch 'release-0.15' into dismiss-tour-from-overlay
harshilsharma63 Mar 9, 2022
278ca03
Fixed intended behavio
harshilsharma63 Mar 9, 2022
6afe4b8
Merge branch 'main' into dismiss-tour-from-overlay
harshilsharma63 Mar 10, 2022
3cd76a0
lint fixes
harshilsharma63 Mar 11, 2022
3f64a5a
Fixed tests
harshilsharma63 Mar 11, 2022
98b25d0
Fixed tests
harshilsharma63 Mar 11, 2022
29e61c2
Merge branch 'main' into dismiss-tour-from-overlay
mattermod Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed tests
  • Loading branch information
@harshilsharma63
harshilsharma63 committed Mar 11, 2022
commit 98b25d01d60063fee2e88883b61bc358613c4a0e
4 changes: 2 additions & 2 deletions webapp/src/components/onboardingTour/addProperties/add_properties.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ const AddPropertiesTourStep = (): JSX.Element | null => {
// and the user is still on the base tour
useEffect(() => {
async function task() {
if (!me) {
if (!me || !card) {
return
}

Expand Down Expand Up @@ -87,7 +87,7 @@ const AddPropertiesTourStep = (): JSX.Element | null => {

// this hack is needed to allow performing async task in useEffect
task()
}, [card.id])
}, [card])

return (
<TourTipRenderer
Expand Down