Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default schema type for focalboard blocks history #2122

Merged
merged 1 commit into from
Jan 16, 2022
Merged

Fix default schema type for focalboard blocks history #2122

merged 1 commit into from
Jan 16, 2022

Conversation

mgdelacroix
Copy link
Contributor

Summary

Set the default schema to 1 in MySQL to match the column type.

Ticket Link

Fixes #2119

@mgdelacroix mgdelacroix added 2: Dev Review Requires review by a core committer CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Jan 15, 2022
@mgdelacroix mgdelacroix requested a review from a team as a code owner January 15, 2022 19:06
@mgdelacroix mgdelacroix removed the request for review from a team January 15, 2022 19:06
wiggin77
wiggin77 approved these changes Jan 15, 2022
View reviewed changes
Copy link
Contributor

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbishel sbishel added this to the v0.12 milestone Jan 16, 2022
sbishel
sbishel approved these changes Jan 16, 2022
View reviewed changes
Copy link
Collaborator

@sbishel sbishel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mgdelacroix

@sbishel sbishel merged commit b92890f into main Jan 16, 2022
@sbishel sbishel deleted the fix-block-history-schema-default-value branch January 16, 2022 00:12
@mattermod
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit to mattermost-build/focalboard that referenced this pull request Jan 16, 2022
@mgdelacroix @mattermost-build
Fix default schema type for focalboard blocks history (mattermost-com…
f61f07a 
…munity#2122)

(cherry picked from commit b92890f)
@mattermost-build mattermost-build mentioned this pull request Jan 16, 2022
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Jan 16, 2022
mgdelacroix added a commit that referenced this pull request Jan 17, 2022
@mattermost-build @mgdelacroix
Fix default schema type for focalboard blocks history (#2122) (#2124)
f40a2b8 
(cherry picked from commit b92890f)

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbishel sbishel sbishel approved these changes

@wiggin77 wiggin77 wiggin77 approved these changes

@jespino jespino Awaiting requested review from jespino

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core committer CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
Milestone
v0.12
Development

Successfully merging this pull request may close these issues.

Bug: Issue upgrading from 6.2.1 to 6.3.0
4 participants
@mgdelacroix @mattermod @wiggin77 @sbishel