Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh 1980 - Updating date picker dates on hover #1981

Merged
merged 4 commits into from
Dec 14, 2021
Merged

Gh 1980 - Updating date picker dates on hover #1981

merged 4 commits into from
Dec 14, 2021

Conversation

asaadmahmood
Copy link
Contributor

Summary

Gh 1980 - Updating date picker dates on hover

Ticket Link

Fixes #1980

@asaadmahmood asaadmahmood requested a review from a team as a code owner December 14, 2021 12:10
@asaadmahmood asaadmahmood requested review from wiggin77 and harshilsharma63 and removed request for a team December 14, 2021 12:10
@asaadmahmood asaadmahmood added 2: Dev Review Requires review by a core committer 2: QA Review Requires review by a QA tester labels Dec 14, 2021
@sbishel sbishel requested a review from ogi-m December 14, 2021 13:42
@sbishel sbishel added the CherryPick/Candidate A candidate for a quality or patch release, but not yet approved label Dec 14, 2021
@sbishel sbishel added this to the v0.11 milestone Dec 14, 2021
wiggin77
wiggin77 approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ogi-m
ogi-m approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@ogi-m ogi-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@ogi-m ogi-m removed the 2: QA Review Requires review by a QA tester label Dec 14, 2021
@sbishel sbishel added CherryPick/Approved Meant for the quality or patch release tracked in the milestone and removed CherryPick/Candidate A candidate for a quality or patch release, but not yet approved labels Dec 14, 2021
@sbishel sbishel merged commit 23a4442 into main Dec 14, 2021
@sbishel sbishel deleted the GH-1980 branch December 14, 2021 16:01
@mattermod
Copy link
Contributor

Cherry pick is scheduled.

@mattermost-build mattermost-build mentioned this pull request Dec 14, 2021
Merged
mattermost-build pushed a commit to mattermost-build/focalboard that referenced this pull request Dec 14, 2021
@asaadmahmood @mattermost-build
Gh 1980 - Updating date picker dates on hover (mattermost-community#1981
995e921 
)

* Updating date UI

* Updating ogi’s issue

* Updating css

* Updating date range css

(cherry picked from commit 23a4442)
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Dec 14, 2021
sbishel pushed a commit that referenced this pull request Dec 14, 2021
@mattermost-build @asaadmahmood
Gh 1980 - Updating date picker dates on hover (#1981) (#1983)
9b122c3 
* Updating date UI

* Updating ogi’s issue

* Updating css

* Updating date range css

(cherry picked from commit 23a4442)

Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogi-m ogi-m ogi-m approved these changes

@wiggin77 wiggin77 wiggin77 approved these changes

@harshilsharma63 harshilsharma63 Awaiting requested review from harshilsharma63 harshilsharma63 was automatically assigned from mattermost/core-focalboard

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core committer CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
Milestone
v0.11
Development

Successfully merging this pull request may close these issues.

Bug: Calendar picker on-hover highlights are mispositioned
5 participants
@asaadmahmood @mattermod @wiggin77 @ogi-m @sbishel