Only allow routes without workspace prefix if you are in non-plugin mode #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespino
requested review from
harshilsharma63,
chenilim and
hahmadia
and removed request for
a team and
chenilim
jespino
added
the
CherryPick/Approved
|
I can approve but I am in favor of testing this before merge as it is touching a brittle part of our codebase that may or may not have effect elsewhere. Just want to confirm we will get testing before I approve. |
sbishel
added
2: Dev Review
sbishel
requested review from
sbishel
and removed request for
harshilsharma63
hahmadia
approved these changes
Nov 9, 2021
sbishel
approved these changes
Nov 9, 2021
ogi-m
added
3: Reviews Complete
|
/cherry-pick |
jespino
added a commit
that referenced
this pull request
Nov 10, 2021
jespino
added
CherryPick/Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1702