Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-856]: Add unit tests for kanbanColumnHeader #1703

Merged
merged 9 commits into from
Nov 15, 2021
Merged

[GH-856]: Add unit tests for kanbanColumnHeader #1703

merged 9 commits into from
Nov 15, 2021

Conversation

jufab
Copy link
Contributor

@jufab jufab commented Oct 29, 2021

Summary

Add unit tests for kanbanColumnHeader

Ticket Link

Fixes #856

@jufab jufab requested a review from a team as a code owner October 29, 2021 22:27
@jufab jufab requested review from jespino and chenilim and removed request for a team October 29, 2021 22:27
@mattermod
Copy link
Contributor

Hello @jufab,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@jufab jufab changed the title chore[GH-#856]: Add unit tests for kanbanColumnHeader [GH-856]: Add unit tests for kanbanColumnHeader Oct 29, 2021
jespino
jespino approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @jufab! ✨

@jespino jespino requested review from harshilsharma63 and removed request for chenilim November 4, 2021 10:39
@jespino
Copy link
Contributor

jespino commented Nov 4, 2021

@harshilsharma63 do you mind to take a look to the calculations part of the tests?

@harshilsharma63 harshilsharma63 merged commit 66a12d1 into mattermost-community:main Nov 15, 2021
@jufab jufab deleted the 856-kanbanColumnHeader branch November 16, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jespino jespino jespino approved these changes

@harshilsharma63 harshilsharma63 harshilsharma63 approved these changes

Assignees
No one assigned
Labels
Contributor Hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebApp Unit Tests for ./webapp/src/components/kanban/kanbanColumnHeader.tsx
4 participants
@jufab @mattermod @jespino @harshilsharma63