-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-1539] Implement searching for the individual words in workspaces #1590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and Worked Well.
I will have QA test this before merging.
@ogi-m Do you mind testing this before we merge it since it affects a critical part of the code base. Thank you
@ogi-m bump :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @De1ain. One issue I'm seeing is this:
- Set up 5 workspaces:
- Workspace
- Workspace 1
- Workspace 11
- Workspace 2
- Workspace 3
- Search on the dashboard, by typing in "workspace"
Observed: Workspace, Workspace 2, Workspace 3 are returned but Workspace 1 and Workspace 11 are not
Expected: All 5 workspaces are returned
Thanks for participating in Hacktoberfest! You can claim your sticker set here: https://get.printfection.com/hacktober21/4144583267 @De1ain |
Fixed in d13d640. Changed the title search pattern. |
/update-branch |
Thanks @De1ain , LGTM 👍🏻 |
Implement searching for the individual words in workspaces
Old behavior:
Simply checking if a search query is a substing of any workspace name, by using
includes
functionNew behavior:
Search now looks for any word (or part of it) from the search query in the names of all workspaces.
Examples:
Have workspaces: 'Workspace 1', 'Workspace 2', and 'Workspace 3'.
Searching for 'Workspace 1' will find all 3 workspaces, because each one contains the word 'workspace'.
Have workspaces: 'Foo Bar Baz'
Seaching for 'foo baz' will find 'Foo Bar Baz'
Update:
Updated first search test name with some description. Updated it's snapshot, according to the new search algorithm changes.
Updated the search filter of the second search test to not include the work workspace, since it will find all 3 workspaces that contain this word.
Add 2 new sample workspace with unique names.
Add 2 new tests.
Fixes #1539