Propagate block changes to all of the cluster nodes in plugin mode #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgdelacroix
added
2: Dev Review
mgdelacroix
force-pushed
the
fix-plugin-message-propagation-ha
branch
5 times, most recently
from
b5dca61 to
af95197
Compare
mgdelacroix
force-pushed
the
fix-plugin-message-propagation-ha
branch
from
af95197 to
ffaecf7
Compare
mgdelacroix
added a commit
that referenced
this pull request
Sep 17, 2021
…1213) Co-authored-by: Jesús Espino <jespinog@gmail.com>
mgdelacroix
added a commit
that referenced
this pull request
Sep 17, 2021
* Update focalboard to be compatible with mattermost v6 (#1020) * Update focalboard to be compatible with mattermost v6 * Point to the new plugin API version * Fix collectors linter issues * Move all CI jobs to 1.16 * Add a plugin adapter to reuse MM websocket in plugin mode (#1079) * Add a plugin adapter to reuse MM websocket in plugin mode * Remove development replace * Switch all go.mod files to use 1.16 * Fix linter issues * Fix linter * Update server version to contain the new hooks * Add retry mechanism when opening WSClient in plugin mode (#1135) * Add retry mechanism when opening WSClient in plugin mode * Fix linter * Add return when sending command * Propagate block changes to all of the cluster nodes in plugin mode (#1213) Co-authored-by: Jesús Espino <jespinog@gmail.com> * Set mattermost-server dependency as the current v6 tip commit Co-authored-by: Jesús Espino <jespinog@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses the plugin API to propagate the block changes to all the plugin nodes, making each node responsible of deciding if they need to distribute a given update to any of their subscribed websockets.
The implementation adds the
sendWorkspaceMessagefunction with the intention of creating a baseline and add more functions if we need to direct messages to other entities in the future.Fixes #1154