Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: web3.js templates #4

Merged
merged 9 commits into from
Feb 16, 2024
Merged

Conversation

avkos
Copy link
Contributor

@avkos avkos commented Feb 6, 2024

What 💻

This PR adds templates how to use web3js with zkSync

CLI PR
Templates PR
web3-zksync-plugin

Why ✋

  • Reason why first thing was added to PR
  • Reason why second thing was added to PR
  • Reason why third thing was added to PR

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

Notes 📝

  • Any notes/thoughts that the reviewers should know prior to reviewing the code?

@avkos avkos requested a review from a team as a code owner February 6, 2024 18:53
@JackHamer09
Copy link
Member

Thanks for your contribution @avkos
Please make changes according to suggestions from @luu-alex (thanks tho!)
Also please make sure there is no package-lock file, since we allow users to use any of the package managers, therefore don't want to provide npm one by default

avkos and others added 2 commits February 8, 2024 10:16
Co-authored-by: Alex  <luu.alex98@gmail.com>
@avkos
Copy link
Contributor Author

avkos commented Feb 8, 2024

Thanks for your contribution @avkos Please make changes according to suggestions from @luu-alex (thanks tho!) Also please make sure there is no package-lock file, since we allow users to use any of the package managers, therefore don't want to provide npm one by default

done. thanks

@JackHamer09 JackHamer09 changed the title web3 js zk-synk plugin templates feat: web3.js templates Feb 15, 2024
@JackHamer09 JackHamer09 merged commit 8f909e7 into matter-labs:main Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants