Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dal): bumps sqlx dependency to 0.7.3 #725

Merged
merged 67 commits into from
Jan 8, 2024
Merged

chore(dal): bumps sqlx dependency to 0.7.3 #725

merged 67 commits into from
Jan 8, 2024

Conversation

montekki
Copy link
Contributor

What ❔

Bumps sqlx dependency to 0.7.3.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via cargo spellcheck --cfg=./spellcheck/era.cfg --code 1.

@montekki montekki requested a review from a team as a code owner December 21, 2023 11:23
popzxc
popzxc reviewed Dec 21, 2023
View reviewed changes
core/lib/utils/Cargo.toml Outdated Show resolved Hide resolved
popzxc
popzxc previously approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fluttershy_yay.gif

slowli
slowli reviewed Dec 21, 2023
View reviewed changes
Copy link
Contributor

@slowli slowli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some new features that we could use (e.g., flattening as mentioned here, or less conversions from byte arrays to Vec<u8>), but they should be tackled in a follow-up PR, IMO.

core/lib/dal/Cargo.toml Outdated Show resolved Hide resolved
popzxc
popzxc previously approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still yay

@montekki montekki requested review from slowli and popzxc January 5, 2024 13:43
popzxc
popzxc previously approved these changes Jan 8, 2024
View reviewed changes
core/lib/dal/src/blocks_dal.rs Show resolved Hide resolved
@montekki montekki added this pull request to the merge queue Jan 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2024
@montekki montekki added this pull request to the merge queue Jan 8, 2024
Merged via the queue into main with commit 7a07f91 Jan 8, 2024
25 checks passed
@montekki montekki deleted the fvs-pla-369-update-sqlx-dependency-to-07 branch January 8, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popzxc popzxc popzxc approved these changes

@artmakh artmakh artmakh approved these changes

@Deniallugo Deniallugo Awaiting requested review from Deniallugo

@yorik yorik Awaiting requested review from yorik yorik is a code owner automatically assigned from matter-labs/devops

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@otani88 otani88 Awaiting requested review from otani88 otani88 is a code owner automatically assigned from matter-labs/devops

@slowli slowli Awaiting requested review from slowli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@montekki @RomanBrodetski @popzxc @slowli @artmakh