-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Integrate tracers and implement circuits tracer in vm2 #2653
Conversation
This reverts commit 8198784.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is performance degradation on iai
benches expected? (AFAIU, it is real degradation compared to the main
branch, e.g. judging by these results on main
.) Have you checked whether it translates to the real-time degradation?
core/lib/multivm/src/versions/vm_fast/tests/tester/transaction_test_info.rs
Outdated
Show resolved
Hide resolved
The slowdown is real but mostly under 10%. heap_read_write shows +15% on my M1 even though it shows no change in iai. |
Detected VM performance changes
Changes in number of opcodes executed indicate that the gas price of the benchmark has changed, which causes it run out of gas at a different time. Or that it is behaving completely differently. |
🤖 I have created a release *beep* *boop* --- ## [24.24.0](core-v24.23.0...core-v24.24.0) (2024-09-05) ### Features * conditional cbt l1 updates ([#2748](#2748)) ([6d18061](6d18061)) * **eth-watch:** do not query events from earliest block ([#2810](#2810)) ([1da3f7e](1da3f7e)) * **genesis:** Validate genesis config against L1 ([#2786](#2786)) ([b2dd9a5](b2dd9a5)) * Integrate tracers and implement circuits tracer in vm2 ([#2653](#2653)) ([87b02e3](87b02e3)) * Move prover data to /home/popzxc/workspace/current/zksync-era/prover/data ([#2778](#2778)) ([62e4d46](62e4d46)) * Remove prover db from house keeper ([#2795](#2795)) ([85b7346](85b7346)) * **vm-runner:** Implement batch data prefetching ([#2724](#2724)) ([d01840d](d01840d)) * **vm:** Extract batch executor to separate crate ([#2702](#2702)) ([b82dfa4](b82dfa4)) * **vm:** Simplify VM interface ([#2760](#2760)) ([c3bde47](c3bde47)) * **zk_toolbox:** add multi-chain CI integration test ([#2594](#2594)) ([05c940e](05c940e)) ### Bug Fixes * **config:** Do not panic for observability config ([#2639](#2639)) ([1e768d4](1e768d4)) * **core:** Batched event processing support for Reth ([#2623](#2623)) ([958dfdc](958dfdc)) * return correct witness inputs ([#2770](#2770)) ([2516e2e](2516e2e)) * **tee-prover:** increase retries to reduce spurious alerts ([#2776](#2776)) ([4fdc806](4fdc806)) * **tee-prover:** mitigate panic on redeployments ([#2764](#2764)) ([178b386](178b386)) * **tee:** lowercase enum TEE types ([#2798](#2798)) ([0f2f9bd](0f2f9bd)) * **vm-runner:** Fix statement timeouts in VM playground ([#2772](#2772)) ([d3cd553](d3cd553)) ### Performance Improvements * **vm:** Fix VM performance regression on CI loadtest ([#2782](#2782)) ([bc0d7d5](bc0d7d5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
What ❔
Integrates tracers support into the codebase and implements the circuits tracer.
Why ❔
Tracers are required for some VM applications, e.g. to determine batch seal criteria and for tracing calls.
Checklist
zk fmt
andzk lint
.