feat(vm): Allow running new VM in state keeper #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
commented
Aug 7, 2024
There was a problem hiding this comment.
It is possible to not run the VM playground in integration tests now and instead run the state keeper with the shadow VM mode. I think the VM playground has its benefits; it could to complete integration tests and then fail if the playground has crashed (but this would optimally require to run it in a separate process which I haven't implemented). Would this approach make sense, or is it overly complicated?
Also, the Protobuf compatibility failure is intentional (caused by redefining experimental VM config in place of the VM playground config). It should disappear when comparing the feature branch and main.
slowli
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet,
otani88,
iluwaa,
montekki,
RomanBrodetski,
popzxc and
joonazan
and removed request for
a team,
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet,
otani88 and
iluwaa
No performance difference detected (anymore) |
RomanBrodetski
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Allows to monitor new VM performance regressions.
Checklist
zk fmtandzk lint.