feat: added a flag to main node to just verify configs (BFT-501) #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pompon0
changed the title
|
Probably I should exclude verification of secrets, at least initially. |
|
after this pr #2545 it doesn't make much sense |
|
We should still have a CI check, assuming anything changes in the code base. I'm happy to see this through, then sent to CI. Maybe it's worthwhile as a separated binary that does only configs, but that's for a different time. |
EmilLuta
approved these changes
Aug 1, 2024
|
I mean ci check is good, but this particular implementation, will show nothing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be used on CI to verify configs in gitops repo.
I've considered implementing it as a subcommand instead of a flag, but afaiu adding flags is the current design pattern. I can change that, lmk wdyt.