-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: base token integration tests #2509
Open
cytadela8
wants to merge
93
commits into
main
Choose a base branch
from
apu-base-token-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+398
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cytadela8
force-pushed
the
apu-base-token-integration
branch
from
July 26, 2024 12:11
e8c0d96
to
36065c2
Compare
cytadela8
commented
Aug 1, 2024
core/node/base_token_adjuster/src/base_token_ratio_persister.rs
Outdated
Show resolved
Hide resolved
cytadela8
force-pushed
the
apu-base-token-integration
branch
from
August 26, 2024 12:40
e6edf29
to
6c1f1af
Compare
it seems |
Due to removal of |
I believe I found where the price was not set properly. Seems this was not "flaky", but permanently broken. pushing a fix... |
also refactored a little how server is configured for fees test
…ext-owner.ts" This reverts commit 7026fa1.
this check was causing problems, becouse for API we multiply l1 gas price by 1.5 (generalConfig.api.web3_json_rpc.gas_price_scale_factor)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist
zk fmt
andzk lint
.