Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upgrade.test.ts): minting from a clean state #2402

Merged
merged 54 commits into from
Aug 21, 2024
Merged

fix(upgrade.test.ts): minting from a clean state #2402

merged 54 commits into from
Aug 21, 2024

Conversation

benceharomi
Copy link
Contributor

@benceharomi benceharomi commented Jul 8, 2024 •
edited
Loading

What ❔

  • fixed a bug that made upgrade test setup fail if it was run from a clean state (without running any other tests previously)
  • erc20 test with max balance deposit cleaned up

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

benceharomi and others added 22 commits July 3, 2024 18:09
Base automatically changed from bh/ci-test to main July 9, 2024 10:41
@benceharomi benceharomi changed the title fix(upgrade.test.ts): gas estimation and mint changes fix(upgrade.test.ts): gas estimation and mint fixes Jul 11, 2024
@benceharomi benceharomi marked this pull request as ready for review July 11, 2024 18:45
@benceharomi benceharomi changed the title fix(upgrade.test.ts): gas estimation and mint fixes fix(upgrade.test.ts): minting from a clean state Jul 23, 2024
benceharomi and others added 16 commits July 23, 2024 23:55
@benceharomi
Revert "fix: from address added to estimateGas"
eab33ed 
This reverts commit 73fc271.
@benceharomi
Revert "manually setting gasLimit and gasPrice"
e4042ca 
This reverts commit 0af08b2.
@benceharomi
Merge branch 'main' into bh/ci-test-2
7b0a318
@benceharomi
Merge branch 'main' into bh/ci-test-2
36a3484
@benceharomi
Merge branch 'main' into bh/ci-test-2
9d256f7
@benceharomi
Merge branch 'main' into bh/ci-test-2
51cfada
@benceharomi
Merge branch 'main' into bh/ci-test-2
44a9113
@benceharomi
Merge branch 'main' into bh/ci-test-2
1b22902
@benceharomi
Merge branch 'main' into bh/ci-test-2
a0a0588
@benceharomi
Merge branch 'main' into bh/ci-test-2
95b2deb
@benceharomi
Merge branch 'main' into bh/ci-test-2
b10b5b5
@benceharomi
Merge branch 'main' into bh/ci-test-2
4b7aa51
@benceharomi
Merge branch 'main' into bh/ci-test-2
9fe92e4
@benceharomi
test(erc20.test.ts): deposit with max balance test cleanup
d1a58e3
@benceharomi
Merge branch 'main' into bh/ci-test-2
e1bd2ca
@benceharomi
Merge branch 'main' into bh/ci-test-2
60204a9
@benceharomi benceharomi added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit efa3bd6 Aug 21, 2024
48 checks passed
@benceharomi benceharomi deleted the bh/ci-test-2 branch August 21, 2024 12:47
@zksync-era-bot zksync-era-bot mentioned this pull request Aug 21, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 21, 2024
@zksync-era-bot
chore(main): release core 24.20.0 (#2703)
161ebdc 
🤖 I have created a release *beep* *boop*
---


##
[24.20.0](core-v24.19.0...core-v24.20.0)
(2024-08-21)


### Features

* Add `gateway_url` to EN config
([#2698](#2698))
([cfdda01](cfdda01))
* **vm:** Enable parallelization in VM playground
([#2679](#2679))
([c9ad59e](c9ad59e))


### Bug Fixes

* base token ratio startup as a separate component
([#2704](#2704))
([d65588f](d65588f))
* **upgrade.test.ts:** minting from a clean state
([#2402](#2402))
([efa3bd6](efa3bd6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deniallugo Deniallugo Deniallugo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benceharomi @Deniallugo