fix: VM performance diff: don't show 0 as N/A #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No performance difference detected (anymore) |
slowli
approved these changes
Jul 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
🤖 I have created a release *beep* *boop* --- ## [24.13.0](core-v24.12.0...core-v24.13.0) (2024-07-31) ### Features * Add recovery tests to zk_supervisor ([#2444](#2444)) ([0c0d10a](0c0d10a)) * Added a JSON RPC to simulating L1 for consensus attestation ([#2480](#2480)) ([c6b3adf](c6b3adf)) * added dropping all attester certificates when doing hard fork ([#2529](#2529)) ([5acd686](5acd686)) * **configs:** Do not panic if config is only partially filled ([#2545](#2545)) ([db13fe3](db13fe3)) * **eth-sender:** Make eth-sender tests use blob txs + refactor of eth-sender tests ([#2316](#2316)) ([c8c8334](c8c8334)) * Introduce more tracing instrumentation ([#2523](#2523)) ([79d407a](79d407a)) * Remove unused VKs, add docs for BWG ([#2468](#2468)) ([2fa6bf0](2fa6bf0)) * Revisit base config values ([#2532](#2532)) ([3fac8ac](3fac8ac)) * Server 10k gwei limit on gas price and 1M limit on pubdata price ([#2460](#2460)) ([be238cc](be238cc)) * **vlog:** Implement otlp guard with force flush on drop ([#2536](#2536)) ([c9f76e5](c9f76e5)) * **vlog:** New vlog interface + opentelemtry improvements ([#2472](#2472)) ([c0815cd](c0815cd)) * **zk_toolbox:** add test upgrade subcommand to zk_toolbox ([#2515](#2515)) ([1a12f5f](1a12f5f)) * **zk_toolbox:** use configs from the main repo ([#2470](#2470)) ([4222d13](4222d13)) ### Bug Fixes * **contract verifier:** Fix config values ([#2510](#2510)) ([3729468](3729468)) * fixed panic propagation ([#2525](#2525)) ([e0fc58b](e0fc58b)) * **proof_data_handler:** Unlock jobs on transient errors ([#2486](#2486)) ([7c336b1](7c336b1)) * **prover:** Parallelize circuit metadata uploading for BWG ([#2520](#2520)) ([f49720f](f49720f)) * VM performance diff: don't show 0 as N/A ([#2276](#2276)) ([2fa2249](2fa2249)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No difference in number of instructions executed now shows as 0 and N/A is only shown when data is missing for some reason.