Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zk init): --run-observability flag #2092

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fborello-lambda
Copy link
Contributor

@fborello-lambda fborello-lambda commented May 29, 2024

What ❔

Run DockProm (Grafana) whenever zk init --run-observability is executed.

Why ❔

This functionality was not working on the main branch. Referencing the commit that implements this feature:
feat: add run-observability to zk (#1359) · matter-labs/zksync-era@2b520f6

How to Reproduce:

  • New dependency: yq
git clone https://github.com/matter-labs/zksync-era.git
cd zksync-era
export ZKSYNC_HOME=$(pwd)
export PATH=$ZKSYNC_HOME/bin:$PATH
zk && zk clean --all && zk env dev && zk init --run-observability && zk server

The port :3000 serves the dashboard.

  • usr: admin
  • pwd: admin

Several transactions were generated in order to test the Grafana's dashboard:

Screenshot 2024-05-29 at 3 33 14 PM

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants