fix(vm): Make execution status and stop reason public #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deniallugo
approved these changes
Oct 6, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
=======================================
Coverage 31.58% 31.58%
=======================================
Files 478 478
Lines 25463 25463
=======================================
Hits 8043 8043
Misses 17420 17420 ☔ View full report in Codecov by Sentry. |
hatemosphere
pushed a commit
that referenced
this pull request
Oct 6, 2023
# What ❔ * TracerExecutionStatus and TracerExecutionStopReason are part of the ExecutionEndTracer trait, but they were not publicly available. ## Why ❔ * This breaks external implementations of the ExecutionEndTracer
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
🤖 I have created a release *beep* *boop* --- ## [16.0.0](core-v15.1.1...core-v16.0.0) (2023-10-11) ### ⚠ BREAKING CHANGES * **vm:** Update Refund model ([#181](#181)) ### Features * change chainId to u64 ([#167](#167)) ([f14bf68](f14bf68)) * **merkle tree:** Provide Merkle proofs for tree entries and entry ranges ([#119](#119)) ([1e30d0b](1e30d0b)) * **storage:** save enum indices in RocksDB ([#162](#162)) ([bab099d](bab099d)) * **vm:** Update Refund model ([#181](#181)) ([92b6f59](92b6f59)) ### Bug Fixes * **db:** drop constraint prover_jobs_fri_l1_batch_number_fkey ([#173](#173)) ([fa71650](fa71650)) * **vm:** Make execution status and stop reason public ([#169](#169)) ([f98c4fa](f98c4fa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔