Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the error message for missing zk compiler output #82

Merged
merged 1 commit into from
May 16, 2023

Conversation

tmrtx
Copy link

@tmrtx tmrtx commented May 16, 2023

Command:

zkforge zk-create src/Counter.sol:Counter --chain 280 --rpc-url https://zksync2-testnet.zksync.dev:443 --private-key "PK"

Before:

The application panicked (crashed).
Message:  Unable to read file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
Location: cli/src/cmd/forge/zk_create.rs:324

After:

The application panicked (crashed).
Message:  Unable to read contract output file at /onchain/hello-world/zkout/Counter.sol/artifacts.json: Os { code: 2, kind: NotFound, message: "No such file or directory" }
Location: cli/src/cmd/forge/zk_create.rs:325

Copy link

@sammyshakes sammyshakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks

@sammyshakes sammyshakes merged commit c955868 into matter-labs:main May 16, 2023
@berryhill
Copy link

@tmrtx first official open source PR, thank you!

@tmrtx
Copy link
Author

tmrtx commented May 17, 2023

@tmrtx first official open source PR, thank you!

thanks @berryhill!

mm-zk added a commit that referenced this pull request Aug 10, 2023
Re-applying all the zksync speicific changes on top of the fresh fork

* chore(security): add workflow for leaked secrets monitoring

* Implement zk-build, zk-create, zk-cast, & zk-deposit cmds

* improve the error message for missing zk compiler output (#82)

Co-authored-by: Tamer Tas <tmrtx@noreply>

* Zkutils comments (#81)

* zk_utils comment

* update developer comments for zkutils and zksolc

* update doc

* Update README.md

* Update README.md

* Added troubleshooting section to README. (#84)

Better error handling for failed transactions

* Added better error messages when file or contract name is not correct (#86)

* updated cargo lock to use the newer version of zksync era (#87)

* Added support for Macs with Apple Silicon (#90)

Added support for Macs with Apple Silicon:

selecting proper zksync compiler
information on where to get the most recent solidity

* Improved message on compiler error and added support for 1.3.10 (#91)

* added better compiler error passing and support for version 1.3.10

* added comments

* more instructions

* more info

* Added a dependency on ethers-rs fork to support latest solidity (#92)

We're currently based off the old fork of foundry, that was depending on the old version of ethers-rs, which supported the solc compiler only up to 0.8.17 (especially on Apple Silicon).

With this PR, I'm moving us to depend on a fork of ethers-rs, that has svm (solidity version manager) patched to the newest release - therefore allowing us to support 0.8.20.

In the near future, we'll rebase ourselves to newer version of foundry, and this dependency would be switched back to original ethers repo.

* fix test compilation issue (#88)

* Adding support for the newest 1.3.11 zksolc compiler (#95)

* Fix flags for zk deposit (#94)

Fix flags used by zk-deposit:

Use --l1-url and --l2-url (and ignore the --rpc-url flag)

* edited README

* typos

* one more typo

* updates from comments

* Fixed compilation issue (#101)

* fix(readme): --is-system flag image (#103)

* Replace `zksync` crate with `zksync_web3_rs` (#110)

* WIP deposit using zksync_ethers_rs

* WIP deposit and test script

* Add zksync rust sdk as dependency

* Use withdraw from Rust SDK

* Add to address as parameter for withdraw

* WIP test

* Add support for multiple flags in withdraw

* Update cargo.lock

* Use Rust SDK to send transactions to contracts

* Fix deposit test

* Support all parameter types for send command

* Add optional fields to deposit

* Add missing deposit parameters

* Cleanup

* wip.

* Deploy with constructor parameters

* Remove unwraps and commented code

* Fix operator_tip setter

* Remove legacy test script

* point zksync-web3-rs to main

* revert cargo.toml autoformat

* Fix create.

* Remove zksync dependencies.

* Update deploy with new signature from Rust SDK

* Add support for construction parameters from file.

* Update function to get constructor arguments

* Add back chain id to every zk function.

* Minor cleanups and consistency. (#9)

* Add transaction id to print after deploy

* Fix compiler warnings

* Update zksync-web3-rs commit in dependencies

* Add necessary changes with new SDK version

---------

Co-authored-by: Joaquín P. Centeno <jpcenteno@users.noreply.github.com>
Co-authored-by: IAvecilla <iavecilla@fi.uba.ar>
Co-authored-by: Matías Onorato <onoratomatias@gmail.com>

* fixed compilation issues

---------

Co-authored-by: Maksym <maksym.kryva@gmail.com>
Co-authored-by: sam shakespeare <sam.shakespeare@gmail.com>
Co-authored-by: tmrtx <133356194+tmrtx@users.noreply.github.com>
Co-authored-by: Tamer Tas <tmrtx@noreply>
Co-authored-by: Sam Shakespeare <76663878+sammyshakes@users.noreply.github.com>
Co-authored-by: Katharine <km@matterlabs.dev>
Co-authored-by: niramisa <50398315+kailash-manasarovar@users.noreply.github.com>
Co-authored-by: evmcheb <50129617+evmcheb@users.noreply.github.com>
Co-authored-by: Martin Paulucci <martin.c.paulucci@gmail.com>
Co-authored-by: Joaquín P. Centeno <jpcenteno@users.noreply.github.com>
Co-authored-by: IAvecilla <iavecilla@fi.uba.ar>
Co-authored-by: Matías Onorato <onoratomatias@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants