Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[do not merge] Experimenting with static strategy #789

Closed
wants to merge 27 commits into from
Closed

[do not merge] Experimenting with static strategy #789

wants to merge 27 commits into from

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Dec 18, 2024

WIP attempt to switch to a static state-based strategy pattern.

At the time of writing, only Backend strategy is in works.

nbaztec and others added 27 commits December 12, 2024 14:55
@nbaztec
add strategy objects
f1c871c
@nbaztec
remove unused parts
b38109d
@nbaztec
fix test build
57f32f2
@nbaztec
remove use_zk completely, fix ExecutorStrategy trait
06aedf4
@nbaztec
fix deadlock
5d77f8c
@nbaztec
clippy
6c00749
@nbaztec
fix tests, startup bug
b5fd952
@nbaztec
switch to try_lock to prevent deadlocks
9009698
@nbaztec
revert try_lock
bee659d
@nbaztec
noop instead of panic on zksync methods for evm, clippy
b5b7e5f
@nbaztec
fix warp and roll
5ee99fc
@nbaztec
fix script
2151459
@nbaztec
make call immutable
e9fbf13
@nbaztec
deep clone strategies on clone
7b23078
@nbaztec
trigger ci
095903b
@nbaztec
revert unintended change
da60354
@nbaztec
Merge branch 'main' into nish-abstraction-strategy
f740454
@nbaztec
fix zk cheatcodes in evm context
193f955
@nbaztec
fix get_code, remove unintended sleep
a506866
@nbaztec
fix script test, clippy
0e9c64f
@nbaztec
Merge branch 'main' into nish-abstraction-strategy
589c8ba
@nbaztec
fix zk_env
f0d0f9d
@nbaztec
guard zk provider
d80312f
@nbaztec
use blocking provider call
bdba380
@nbaztec
Merge branch 'main' into nish-abstraction-strategy
53d5d9a
@nbaztec
use Box instead of Arc<Mutex<T>>
1876c01
@popzxc
chore: snapshot
d92ad57
@popzxc popzxc requested a review from a team as a code owner December 18, 2024 08:30
@Karrq Karrq added the do not merge 🛑 Do not merge this PR until label is removed label Dec 19, 2024
Base automatically changed from nish-abstraction-strategy to main December 20, 2024 10:30
@nbaztec nbaztec closed this Jan 29, 2025
@nbaztec nbaztec deleted the popzxc-static-strategy branch January 29, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not merge 🛑 Do not merge this PR until label is removed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@popzxc @nbaztec @Karrq