Toolbar: icon from one view A gets added to view B

[alelordelo]

When used on MacOS, on PushView the toolbar icon from one view A gets added to view B.

Did anyone else experience this?

[alelordelo]

Hi @mattevigo, I am trying to solve this but still did not find a way around... Did you also experience this?

[matteopuc]

Hi @alelordelo, would you be able to provide us with a code snippet to help you debug the issue? Maybe the .toolbar modifier is attached to the wrong view, but it's just a guess. Thanks.

[alelordelo]

Hi @matteopuc , there you go!

Note that the view B gets toolbar icons also from view A.

import SwiftUI
import NavigationStack



struct SidebarView: View {
    var body: some View {
        NavigationView {
            
            List {

                NavigationLink(destination: ViewA()) {
                        Label("Message", systemImage: "message")
                    }
            }
            .listStyle(SidebarListStyle())
            .navigationTitle("Explore")
            .frame(minWidth: 150, idealWidth: 250, maxWidth: 300)
            .toolbar{

            }
            //view A
            ViewA()
        }
    }
}

struct ViewA: View {
    
    
    var body: some View {
        
        NavigationStackView {

        VStack {
            
            //PushView(destination: FabricDetailPublicHStack(post: post)) {

                PushView(destination: ViewB()) {

            Text("A -> B Push")
            }
        }
        }
        .navigationTitle("A")
        
        .toolbar {

            ToolbarItem(placement: .status) {
       
            Image(systemName: "a.circle.fill")
   
            }

 
        }
    }
}

struct ViewB: View {
    var body: some View {
        
        VStack(alignment: .leading) {

            PopView {
                Image(systemName: "chevron.backward")
            }
          
            Text("B")
        }
        
        .navigationTitle("B")
        
        .toolbar {

            ToolbarItem(placement: .confirmationAction) {
       
            Image(systemName: "b.circle.fill")
   
            }

 
        }
        
    }
}

[alelordelo]

[matteopuc]

Hi @alelordelo, thanks for the code snippet. Here is the solution: you have to move the

.toolbar {
    ToolbarItem(placement: .status) {
        Image(systemName: "a.circle.fill")
    }
}

of the ViewA inside the NavigationStackView. When you use the NavigationStackView to navigate you are basically changing it's content and not the NavigationStackView itself. If you attach a toolbar item to the NavigationStackView you'll always see that item (because the navigation stack view actually never disappears). Here is the complete solution:

import SwiftUI
import NavigationStack


struct SidebarView: View {
    var body: some View {
        NavigationView {
            List {
                NavigationLink(destination: ViewA()) {
                    Label("Message", systemImage: "message")
                }
            }
            .listStyle(SidebarListStyle())
            .navigationTitle("Explore")
            .frame(minWidth: 150, idealWidth: 250, maxWidth: 300)
            ViewA()
        }
    }
}

struct ViewA: View {
    var body: some View {
        NavigationStackView {
            VStack {
                PushView(destination: ViewB()) {
                    Text("A -> B Push")
                }
                .toolbar {
                    ToolbarItem(placement: .status) {
                        Image(systemName: "a.circle.fill")
                    }
                }
            }
        }
        .navigationTitle("A")
    }
}

struct ViewB: View {
    var body: some View {
        VStack(alignment: .leading) {
            PopView {
                Image(systemName: "chevron.backward")
            }
            Text("B")
        }
        .navigationTitle("B")
        .toolbar {
            ToolbarItem(placement: .confirmationAction) {
                Image(systemName: "b.circle.fill")
            }
        }
    }
}

The result is:

[alelordelo]

ahhh, it was that simple! thanks a ton again Matteo!