Update USB implementation, fix 64 bytes bug#45
Open
qbolsee wants to merge 63 commits intomattairtech:masterfrom
Open
Update USB implementation, fix 64 bytes bug#45qbolsee wants to merge 63 commits intomattairtech:masterfrom
qbolsee wants to merge 63 commits intomattairtech:masterfrom
Conversation
|
Sigh. That's awful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bugfix for a specific issue when sending exactly 64 bytes to the USB CDC. It seems the bytes were stuck in a buffer which was only released when reaching 256 bytes. I can upload a test case that demonstrates this if needed.
Updating
SAMD21_USBDevice.hto the version from the official Arduino Core fixed the issue.