fix(runtime): The preload link is inserted without specific purpose (m…

…odule-federation#2152)
matt-pawley · Mar 6, 2024 · 3a45d99 · 3a45d99
1 parent 637dcfc
commit 3a45d99
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/.changeset/itchy-ravens-give.md b/.changeset/itchy-ravens-give.md
@@ -0,0 +1,5 @@
+---
+'@module-federation/sdk': patch
+---
+
+fix: Avoid style loss due to reuse of link without distinguishing purpose
diff --git a/packages/sdk/src/dom.ts b/packages/sdk/src/dom.ts
@@ -98,7 +98,7 @@ export function createScript(
 export function createLink(
   url: string,
   cb: (value: void | PromiseLike<void>) => void,
-  attrs?: Record<string, any>,
+  attrs: Record<string, string> = {},
   createLinkHook?: (url: string) => HTMLLinkElement | void,
 ) {
   // <link rel="preload" href="script.js" as="script">
@@ -110,7 +110,12 @@ export function createLink(
   for (let i = 0; i < links.length; i++) {
     const l = links[i];
     const linkHref = l.getAttribute('href');
-    if (linkHref && isStaticResourcesEqual(linkHref, url)) {
+    const linkRef = l.getAttribute('ref');
+    if (
+      linkHref &&
+      isStaticResourcesEqual(linkHref, url) &&
+      linkRef === attrs['ref']
+    ) {
       link = l;
       needAttach = false;
       break;