Marker for baseline callbacks

Summary: @public Wraps baseline callbacks with a marker. Reviewed By: SidharthGuglani Differential Revision: D13896861 fbshipit-source-id: 848ec697977a0a68b9943f1159f6562d54724f89
matt-oakes · Feb 1, 2019 · 7725d07 · 7725d07
1 parent 7835f1b
commit 7725d07
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/ReactCommon/yoga/yoga/YGMarker.h b/ReactCommon/yoga/yoga/YGMarker.h
@@ -16,6 +16,7 @@ typedef struct YGConfig* YGConfigRef;
 typedef YG_ENUM_BEGIN(YGMarker){
     YGMarkerLayout,
     YGMarkerMeasure,
+    YGMarkerBaselineFn,
 } YG_ENUM_END(YGMarker);
 
 typedef struct {
@@ -66,14 +67,19 @@ struct MarkerData<YGMarkerLayout> {
   }
 };
 
-template <>
-struct MarkerData<YGMarkerMeasure> {
+struct NoMarkerData {
   using type = YGMarkerNoData;
   static type*& get(YGMarkerData& d) {
     return d.noData;
   }
 };
 
+template <>
+struct MarkerData<YGMarkerMeasure> : NoMarkerData {};
+
+template <>
+struct MarkerData<YGMarkerBaselineFn> : NoMarkerData {};
+
 } // namespace detail
 
 template <YGMarker M>

diff --git a/ReactCommon/yoga/yoga/Yoga.cpp b/ReactCommon/yoga/yoga/Yoga.cpp
@@ -1074,7 +1074,9 @@ static inline YGAlign YGNodeAlignItem(
 
 static float YGBaseline(const YGNodeRef node) {
   if (node->getBaseline() != nullptr) {
-    const float baseline = node->getBaseline()(
+    const float baseline = marker::MarkerSection<YGMarkerBaselineFn>::wrap(
+        node,
+        node->getBaseline(),
         node,
         node->getLayout().measuredDimensions[YGDimensionWidth],
         node->getLayout().measuredDimensions[YGDimensionHeight]);