Refactor FabricBinding class

Summary: This diff removes the FabricBinding interface becuase it is not needed anymore. Reviewed By: sahrens Differential Revision: D13707494 fbshipit-source-id: 7b50dcd40559356464a860ba32d9a0130ab2da6e
matt-oakes · Jan 17, 2019 · 0eea0fc · 0eea0fc
1 parent 58f2acf
commit 0eea0fc
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 30 deletions.
diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricBinding.java b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricBinding.java
diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricJSIModuleProvider.java b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricJSIModuleProvider.java
@@ -39,7 +39,7 @@ public UIManager get() {
     final FabricUIManager uiManager = createUIManager(eventBeatManager);
     Systrace.beginSection(
         Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "FabricJSIModuleProvider.registerBinding");
-    final FabricBinding binding = new Binding();
+    final Binding binding = new Binding();
     MessageQueueThread jsMessageQueueThread =
         mReactApplicationContext
             .getCatalystInstance()

diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/jsi/Binding.java b/ReactAndroid/src/main/java/com/facebook/react/fabric/jsi/Binding.java
@@ -12,13 +12,12 @@
 import com.facebook.react.bridge.JavaScriptContextHolder;
 import com.facebook.react.bridge.NativeMap;
 import com.facebook.react.bridge.queue.MessageQueueThread;
-import com.facebook.react.fabric.FabricBinding;
 import com.facebook.react.fabric.FabricUIManager;
 import com.facebook.react.uimanager.PixelUtil;
 
 @DoNotStrip
 @SuppressLint("MissingNativeLoadLibrary")
-public class Binding implements FabricBinding {
+public class Binding {
 
   static {
     FabricSoLoader.staticInit();
@@ -50,7 +49,6 @@ private native void installFabricUIManager(
   public native void setConstraints(
       int rootTag, float minWidth, float maxWidth, float minHeight, float maxHeight);
 
-  @Override
   public void register(
        JavaScriptContextHolder jsContext,
        FabricUIManager fabricUIManager,
@@ -65,7 +63,6 @@ public void register(
 
   private native void uninstallFabricUIManager();
 
-  @Override
   public void unregister() {
     uninstallFabricUIManager();
   }