feat(angular): update the existing files + add the new angular (renaissance) practices #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LcsGa
force-pushed
the
feature/angular-renaissance
branch
2 times, most recently
from
2e5426f
to
9d57e98
Compare
…ssance) practices
LcsGa
force-pushed
the
feature/angular-renaissance
branch
from
9d57e98
to
e4f2c7e
Compare
|
The build is failing, can you fix it ? As I said it's surely because of a change in |
|
I can take another look at it tomorrow but I couldn't find what was the issue there |
|
Well, I took a look at the code of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the issue #241