Speeding up external IP discovery by using dig and opendns #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Full disclosure: I work for OpenDNS :) I ❤️ this but I may be biased. I don't think we should require Travis-CI complaince since it's the original code that's failing and not you're actual changes. But I'd like @matryer or @keithamus to 👍 this first. |
|
Seems fine by me. |
tresni
added a commit
that referenced
this pull request
Mar 18, 2016
Speeding up external IP discovery by using dig and opendns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNS lookups are faster than http requests.