Fixed a bug that caused the system to stuck after packet loss during data loading #23390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengttt
reviewed
Dec 29, 2025
Contributor
fengttt
left a comment
fengttt
left a comment
There was a problem hiding this comment.
In general I don't think tweaking timeout is the right fix for a system hung.
What is the real "case" for hung? And what error we generate?
Contributor
Author
The real stuck during the load phase is here: https://github.com/matrixorigin/matrixone/blob/main/pkg/frontend/mysql_buffer.go#L569. Because the read timeout is 24 hours, if the connection isn't closed, the read operation will get stuck indefinitely, repeatedly returning an EOF error after 4 hours or 40 minutes. |
fengttt
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue https://github.com/matrixorigin/MO-Cloud/issues/6448
What this PR does / why we need it:
Fixed a bug that caused the system to stuck after packet loss during data loading
The network read timeout is 24 hours; if packets are lost, it will wait indefinitely.