-
Notifications
You must be signed in to change notification settings - Fork 288
merge redundant join operators into HashJoin Part 1 #23349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fengttt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not right -- how come this will have more added code that removed?
Did you forget to remove 2 join operators? Or it is still intermediate step and you will remove later?
It's still WIP. Some old code have not been deleted. |
Fixed and added bvt cases |
Merge Queue Status✅ The pull request has been merged at 6cd026e This pull request spent 6 seconds in the queue, with no time running CI. Required conditions to merge
|
What type of PR is this?
Which issue(s) this PR fixes:
issue #23318
What this PR does / why we need it:
This PR merges INNER/LEFT/RIGHT/SINGLE join operators into one HashJoin. Advantages: