Skip to content

Conversation

@Ariznawlll
Copy link
Contributor

@Ariznawlll Ariznawlll commented Nov 3, 2025

User description

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

rm tag 19998

issue ##19998
https://github.com/matrixorigin/MO-Cloud/issues/5762
https://github.com/matrixorigin/MO-Cloud/issues/6325

What this PR does / why we need it:

rm tag 19998


PR Type

Bug fix


Description


Diagram Walkthrough

flowchart LR
  A["Issue #19998<br/>Placeholder Result"] -- "Replace with<br/>Actual Results" --> B["Valid Query Output<br/>15 Result Rows"]
  C["Test Annotations<br/>@bvt:issue#19998"] -- "Remove Tags" --> D["Clean Test Case"]
Loading

File Walkthrough

Relevant files
Bug fix
rollup.result
Update rollup test with actual expected results                   

test/distributed/cases/window/rollup.result

  • Replace [unknown result because it is related to issue#19998]
    placeholder with 15 actual query result rows
  • Add complete expected output for ROLLUP query with year, quarter,
    region, and total_sales columns
  • Results show aggregated sales data at multiple grouping levels
+16/-1   
rollup.sql
Remove issue tracking annotations from test                           

test/distributed/cases/window/rollup.sql

  • Remove -- @bvt:issue#19998 annotation from test case
  • Remove -- @bvt:issue annotation before drop table statement
  • Clean up test file by removing issue tracking comments
+0/-2     

@Ariznawlll Ariznawlll requested a review from heni02 as a code owner November 3, 2025 09:47
@CLAassistant
Copy link

CLAassistant commented Nov 3, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Ariznawlll
Ariznawl@163.com


Ariznawl@163.com seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@qodo-merge-pro
Copy link

qodo-merge-pro bot commented Nov 3, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status:
No audit scope: The PR only updates test SQL and expected results without affecting application logic or
audit logging, so audit requirements cannot be evaluated from the added lines.

Referred Code
-- alias
select
    if(grouping(year), 'All years', year) as year,
    if(grouping(quarter), 'Quarter', quarter) as quarter,
    region,
Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status:
No error paths: The added lines are test queries and expected outputs without executable error handling,
so robustness of error handling cannot be determined from this diff.

Referred Code
group by
    year,
    quarter,
    region with rollup
order by total_sales desc;
drop table sales;
Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status:
Test-only changes: The modifications update test expectations and remove issue tags without introducing input
handling logic, so validation and security implications cannot be assessed based on the
added lines.

Referred Code
year    quarter    region    total_sales
All years    Quarter    null    220000.00
2022    Quarter    null    150000.00
2022    2    null    85000.00
2021    Quarter    null    70000.00
2022    1    null    65000.00
2021    2    null    45000.00
2022    2    South    45000.00
2022    2    North    40000.00
2022    1    South    35000.00
2022    1    North    30000.00
2021    1    null    25000.00
2021    2    South    25000.00
2021    2    North    20000.00
2021    1    South    15000.00
2021    1    North    10000.00
  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@matrix-meow matrix-meow added the size/S Denotes a PR that changes [10,99] lines label Nov 3, 2025
@qodo-merge-pro
Copy link

qodo-merge-pro bot commented Nov 3, 2025

PR Code Suggestions ✨

No code suggestions found for the PR.

@mergify mergify bot added the kind/bug Something isn't working label Nov 3, 2025
@matrix-meow matrix-meow added size/M Denotes a PR that changes [100,499] lines and removed size/S Denotes a PR that changes [10,99] lines labels Nov 4, 2025
@Ariznawlll Ariznawlll changed the title Rmtag19998 Rmtag19998 and Nov 4, 2025
@Ariznawlll Ariznawlll changed the title Rmtag19998 and Rmtag19998 and add some case Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working size/M Denotes a PR that changes [100,499] lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants