Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not omit 0 replica #556

Merged
merged 2 commits into from
Oct 12, 2024
Merged

fix: do not omit 0 replica #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e859e9
fix: do not omit 0 replica
aylei Oct 12, 2024
8559c1d
fix
aylei Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions api/core/v1alpha1/common_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@ type PodSet struct {
Overlay *Overlay `json:"overlay,omitempty"`

// Replicas is the desired number of pods of this set
// +optional
Replicas int32 `json:"replicas,omitempty"`
Replicas int32 `json:"replicas"`

// TopologyEvenSpread specifies what topology domains the Pods in set should be
// evenly spread in.
Expand Down
2 changes: 2 additions & 0 deletions charts/matrixone-operator/templates/crds/core.matrixorigin.io_cnpools.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,8 @@ spec:
can be unavailable during the update process.
x-kubernetes-int-or-string: true
type: object
required:
- replicas
type: object
required:
- deps
Expand Down
2 changes: 2 additions & 0 deletions charts/matrixone-operator/templates/crds/core.matrixorigin.io_cnsets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,8 @@ spec:
can be unavailable during the update process.
x-kubernetes-int-or-string: true
type: object
required:
- replicas
type: object
status:
description: CNSetStatus Figure out what status should be exposed
Expand Down
2 changes: 2 additions & 0 deletions charts/matrixone-operator/templates/crds/core.matrixorigin.io_dnsets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,8 @@ spec:
items:
type: string
type: array
required:
- replicas
type: object
status:
properties:
Expand Down
1 change: 1 addition & 0 deletions charts/matrixone-operator/templates/crds/core.matrixorigin.io_logsets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ spec:
type: string
type: object
required:
- replicas
- sharedStorage
- volume
type: object
Expand Down
14 changes: 14 additions & 0 deletions charts/matrixone-operator/templates/crds/core.matrixorigin.io_matrixoneclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,8 @@ spec:
can be unavailable during the update process.
x-kubernetes-int-or-string: true
type: object
required:
- replicas
type: object
cnGroups:
description: CNGroups are CN pod sets that have different spec like
Expand Down Expand Up @@ -770,6 +772,7 @@ spec:
type: object
required:
- name
- replicas
type: object
type: array
x-kubernetes-list-map-keys:
Expand Down Expand Up @@ -959,6 +962,8 @@ spec:
items:
type: string
type: array
required:
- replicas
type: object
imagePullPolicy:
description: PullPolicy describes a policy for if/when to pull a container
Expand Down Expand Up @@ -1252,6 +1257,7 @@ spec:
type: string
type: object
required:
- replicas
- sharedStorage
- volume
type: object
Expand Down Expand Up @@ -1421,6 +1427,8 @@ spec:
items:
type: string
type: array
required:
- replicas
type: object
restoreFrom:
type: string
Expand Down Expand Up @@ -1614,6 +1622,8 @@ spec:
items:
type: string
type: array
required:
- replicas
type: object
topologySpread:
description: |-
Expand Down Expand Up @@ -1973,6 +1983,8 @@ spec:
can be unavailable during the update process.
x-kubernetes-int-or-string: true
type: object
required:
- replicas
type: object
version:
description: |-
Expand Down Expand Up @@ -2141,6 +2153,8 @@ spec:
can be unavailable during the update process.
x-kubernetes-int-or-string: true
type: object
required:
- replicas
type: object
required:
- logService
Expand Down
2 changes: 2 additions & 0 deletions charts/matrixone-operator/templates/crds/core.matrixorigin.io_proxysets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,8 @@ spec:
items:
type: string
type: array
required:
- replicas
type: object
status:
properties:
Expand Down
2 changes: 2 additions & 0 deletions charts/matrixone-operator/templates/crds/core.matrixorigin.io_webuis.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,8 @@ spec:
can be unavailable during the update process.
x-kubernetes-int-or-string: true
type: object
required:
- replicas
type: object
status:
properties:
Expand Down
2 changes: 2 additions & 0 deletions deploy/crds/core.matrixorigin.io_cnpools.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,8 @@ spec:
can be unavailable during the update process.
x-kubernetes-int-or-string: true
type: object
required:
- replicas
type: object
required:
- deps
Expand Down
2 changes: 2 additions & 0 deletions deploy/crds/core.matrixorigin.io_cnsets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,8 @@ spec:
can be unavailable during the update process.
x-kubernetes-int-or-string: true
type: object
required:
- replicas
type: object
status:
description: CNSetStatus Figure out what status should be exposed
Expand Down
2 changes: 2 additions & 0 deletions deploy/crds/core.matrixorigin.io_dnsets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,8 @@ spec:
items:
type: string
type: array
required:
- replicas
type: object
status:
properties:
Expand Down
1 change: 1 addition & 0 deletions deploy/crds/core.matrixorigin.io_logsets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ spec:
type: string
type: object
required:
- replicas
- sharedStorage
- volume
type: object
Expand Down
14 changes: 14 additions & 0 deletions deploy/crds/core.matrixorigin.io_matrixoneclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,8 @@ spec:
can be unavailable during the update process.
x-kubernetes-int-or-string: true
type: object
required:
- replicas
type: object
cnGroups:
description: CNGroups are CN pod sets that have different spec like
Expand Down Expand Up @@ -770,6 +772,7 @@ spec:
type: object
required:
- name
- replicas
type: object
type: array
x-kubernetes-list-map-keys:
Expand Down Expand Up @@ -959,6 +962,8 @@ spec:
items:
type: string
type: array
required:
- replicas
type: object
imagePullPolicy:
description: PullPolicy describes a policy for if/when to pull a container
Expand Down Expand Up @@ -1252,6 +1257,7 @@ spec:
type: string
type: object
required:
- replicas
- sharedStorage
- volume
type: object
Expand Down Expand Up @@ -1421,6 +1427,8 @@ spec:
items:
type: string
type: array
required:
- replicas
type: object
restoreFrom:
type: string
Expand Down Expand Up @@ -1614,6 +1622,8 @@ spec:
items:
type: string
type: array
required:
- replicas
type: object
topologySpread:
description: |-
Expand Down Expand Up @@ -1973,6 +1983,8 @@ spec:
can be unavailable during the update process.
x-kubernetes-int-or-string: true
type: object
required:
- replicas
type: object
version:
description: |-
Expand Down Expand Up @@ -2141,6 +2153,8 @@ spec:
can be unavailable during the update process.
x-kubernetes-int-or-string: true
type: object
required:
- replicas
type: object
required:
- logService
Expand Down
2 changes: 2 additions & 0 deletions deploy/crds/core.matrixorigin.io_proxysets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,8 @@ spec:
items:
type: string
type: array
required:
- replicas
type: object
status:
properties:
Expand Down
2 changes: 2 additions & 0 deletions deploy/crds/core.matrixorigin.io_webuis.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,8 @@ spec:
can be unavailable during the update process.
x-kubernetes-int-or-string: true
type: object
required:
- replicas
type: object
status:
properties:
Expand Down
Loading