fix: cn in the Bound phase should not be scaled in first #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aylei
reviewed
Aug 26, 2024
| } | ||
|
|
||
| func (s *StoreScore) GenDeletionCost() int { | ||
| return s.SessionCount | ||
| deletionCost := s.SessionCount*sessionWeight + s.PipelineCount*pipelineWeight |
There was a problem hiding this comment.
sessionCount and pipelineCount can go easily over phaseWeight, e.g. serving 1000 sessions in one host is a common case
Comment on lines
+173
to
+174
| for deletionCost > maxCost { | ||
| deletionCost >>= 1 |
There was a problem hiding this comment.
buggy: maxCost would be larger than maxCost+1 after normalization
aylei
requested changes
Aug 26, 2024
|
fixed in #547 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
Fixes #
https://github.com/matrixorigin/MO-Cloud/issues/3920
What this PR does / why we need it:
Not Available
Special notes for your reviewer:
Not Available
Additional documentation (e.g. design docs, usage docs, etc.):
Not Available