Skip to content

Update "Event with an invalid signature in the send_join response should not cause room join to fail" #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
neilalexander merged 1 commit into from
Oct 7, 2020
Merged

Update "Event with an invalid signature in the send_join response should not cause room join to fail" #963

neilalexander merged 1 commit into from
Oct 7, 2020

Conversation

@neilalexander
Copy link
Contributor

@neilalexander neilalexander commented Oct 1, 2020

Changing the origin field seemingly triggers the Event ID domain <-> Origin and Sender Domain <-> Origin checks, which is not great.

@neilalexander
Fix test so that we don't mangle origin-eventID or origin-sender rela…
a8745cb 
…tionship when breaking sig (otherwise the test triggers *other* problems)
@neilalexander neilalexander requested a review from kegsay October 1, 2020 17:06
@neilalexander neilalexander merged commit 48865b0 into develop Oct 7, 2020
@neilalexander neilalexander deleted the neilalexander/fixinvalidsigtest branch October 7, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kegsay kegsay kegsay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neilalexander @kegsay