Attempt to deflake Device list doesn't change if remote server is down
#1142
Conversation
|
Slightly concerned that I've made things worse for Dendrite somehow. |
tests/50federation/40devicelists.pl
Outdated
| # replication | ||
| # | ||
| # Sync so that we have a chance for the replication to propagate. | ||
| sync_until_user_in_device_list($local_user, new_User(user_id=>$outbound_client_user, http=>"", server_name=>"")); |
There was a problem hiding this comment.
| sync_until_user_in_device_list($local_user, new_User(user_id=>$outbound_client_user, http=>"", server_name=>"")); | |
| sync_until_user_in_device_list( $local_user, | |
| new_User( user_id => $outbound_client_user, http => "", server_name => "" ) | |
| ); |
I wonder if instead we should change sync_until_user_in_device_list to accept a user ID as the second param? Probably a lot nicer?
There was a problem hiding this comment.
I'd be tempted to make it accept either a User struct or a user ID, if only because I don't want to touch all of the other call sites. I'm not sure if there's a good perl idiom for that?
|
Looks decent enough to me. Dendrite is likely unhappy because you're now relying on device lists in |
Does https://metacpan.org/dist/Perl-Tidy/view/bin/perltidy suffice? |
Co-authored-by: Erik Johnston <erik@matrix.org>
Sorry, I didn't want to go around updating every other call site
|
CI passed for all synapses (sorry Dendrite) |
@kegsay is it worth blacklisting these in Dendrite? (On the one hand I didn't want to suppress the fact that dendrite has an issue there; on the other I don't want to cause people pain by having CI failures across the board.) |
Closes #1136