Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Pin attrs to <21.1.0 #9937

Merged
merged 2 commits into from
May 6, 2021
Merged

Pin attrs to <21.1.0 #9937

merged 2 commits into from
May 6, 2021

Conversation

erikjohnston
Copy link
Member

Fixes #9936

@erikjohnston erikjohnston requested a review from a team May 6, 2021 12:02
@erikjohnston erikjohnston merged commit 24f07a8 into release-v1.33.1 May 6, 2021
@erikjohnston erikjohnston deleted the erikj/pin_attrs branch May 6, 2021 13:06
@erdnaxeli
Copy link
Contributor

I am suprised:

  • that all dependencies's major version are not pinned
  • that synapse does not use a dependencies manager like Pipenv or Poetry

@erikjohnston
Copy link
Member Author

  • that all dependencies's major version are not pinned

A lot of our dependencies don't use semantic versioning, alas.

  • that synapse does not use a dependencies manager like Pipenv or Poetry

That is under active discussion... somewhere I can't find right now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikjohnston @erdnaxeli @anoadragon453