Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/7730.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix missing `Content-Length` on HTTP responses from the metrics handler.
5 changes: 4 additions & 1 deletion synapse/metrics/_exposition.py
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ def do_GET(self):
raise
self.send_response(200)
self.send_header("Content-Type", CONTENT_TYPE_LATEST)
self.send_header("Content-Length", str(len(output)))
self.end_headers()
self.wfile.write(output)

Expand Down Expand Up @@ -261,4 +262,6 @@ def __init__(self, registry=REGISTRY):

def render_GET(self, request):
request.setHeader(b"Content-Type", CONTENT_TYPE_LATEST.encode("ascii"))
return generate_latest(self.registry)
response = generate_latest(self.registry)
request.setHeader(b"Content-Length", str(len(response)))
return response