Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Move get_state methods into FederationHandler #6503

Merged
merged 3 commits into from
Dec 10, 2019
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Dec 10, 2019

This is a non-functional refactor as a precursor to some other work.

Based on #6501

@richvdh richvdh requested a review from a team December 10, 2019 01:18
@erikjohnston
Copy link
Member

Do we need to move them to FederationHandler? Its already quite a big class

The test failures look relevant.

Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

This is a non-functional refactor as a precursor to some other work.
this is called from non-async functions, so we're not ready to async it yet.
@richvdh richvdh mentioned this pull request Dec 10, 2019
@richvdh richvdh merged commit f8bc2ae into develop Dec 10, 2019
@richvdh richvdh deleted the rav/event_auth/11 branch December 10, 2019 17:42
anoadragon453 added a commit that referenced this pull request Dec 11, 2019
…rch_redacted_events

* 'develop' of github.com:matrix-org/synapse: (100 commits)
  Move get_state methods into FederationHandler (#6503)
  Allow SAML username provider plugins (#6411)
  Fix race which caused deleted devices to reappear (#6514)
  Refactor get_events_from_store_or_dest to return a dict (#6501)
  Remove redundant code from event authorisation implementation. (#6502)
  Newsfile
  Silence mypy errors for files outside those specified
  Newsfile
  Phone home stats DB reporting should not assume a single DB.
  Update comment
  Drop unused index
  Convert _censor_redactions to async since it awaits on coroutines
  Only start censor background job after indices are created
  Newsfile
  Newsfile
  Fix make_deferred_yieldable to work with coroutines
  Newsfile
  Fix support for SQLite 3.7.
  Better errors regarding changing avatar_url (#6497)
  1.7.0rc1
  ...
richvdh added a commit that referenced this pull request Dec 16, 2019
This is a non-functional refactor as a precursor to some other work.
richvdh added a commit that referenced this pull request Dec 18, 2019
Synapse 1.7.1 (2019-12-18)
==========================

This release includes several security fixes as well as a fix to a bug exposed by the security fixes. Administrators are encouraged to upgrade as soon as possible.

Security updates
----------------

- Fix a bug which could cause room events to be incorrectly authorized using events from a different room. ([\#6501](#6501), [\#6503](#6503), [\#6521](#6521), [\#6524](#6524), [\#6530](#6530), [\#6531](#6531))
- Fix a bug causing responses to the `/context` client endpoint to not use the pruned version of the event. ([\#6553](#6553))
- Fix a cause of state resets in room versions 2 onwards. ([\#6556](#6556), [\#6560](#6560))

Bugfixes
--------

- Fix a bug which could cause the federation server to incorrectly return errors when handling certain obscure event graphs. ([\#6526](#6526), [\#6527](#6527))
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit 'f8bc2ae88':
  Move get_state methods into FederationHandler (#6503)
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit 'be294d6fd':
  Move get_state methods into FederationHandler (#6503)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants