This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Opentracing end to end encryption #5687
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Jul 17, 2019
richvdh
reviewed
Jul 17, 2019
Member
There was a problem hiding this comment.
typically we include a comment explaining what the new column means.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Author
There was a problem hiding this comment.
How's that?
Member
There was a problem hiding this comment.
it's a bit wordy, to be honest :/. I mean, it's great, but I think it's more detail than we need here.
Opentracing context data for inclusion in the
device_list_updateEDUs, as a json-encoded dictionary
Contributor
Author
There was a problem hiding this comment.
Fair enough
JorikSchellekens
force-pushed
the
joriks/opentracing_e2e
branch
2 times, most recently
from
54d50ca to
7f282d1
Compare
JorikSchellekens
changed the title
JorikSchellekens
changed the base branch from
develop
to
joriks/opentracing_utils
Codecov Report
@@ Coverage Diff @@
## joriks/opentracing_utils #5687 +/- ##
============================================================
- Coverage 63.22% 24.9% -38.32%
============================================================
Files 331 171 -160
Lines 36216 16088 -20128
Branches 5964 2343 -3621
============================================================
- Hits 22897 4007 -18890
- Misses 11688 11996 +308
+ Partials 1631 85 -1546 |
Codecov Report
@@ Coverage Diff @@
## develop #5687 +/- ##
===========================================
+ Coverage 63.33% 63.46% +0.12%
===========================================
Files 331 331
Lines 36584 36563 -21
Branches 6046 6009 -37
===========================================
+ Hits 23172 23205 +33
+ Misses 11760 11712 -48
+ Partials 1652 1646 -6 |
JorikSchellekens
force-pushed
the
joriks/opentracing_utils
branch
2 times, most recently
from
8baeadd to
1345ac8
Compare
JorikSchellekens
changed the base branch from
joriks/opentracing_utils
to
develop
JorikSchellekens
force-pushed
the
joriks/opentracing_e2e
branch
from
33789fc to
03f108d
Compare
JorikSchellekens
force-pushed
the
joriks/opentracing_e2e
branch
from
03f108d to
1801578
Compare
richvdh
suggested changes
Jul 26, 2019
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
JorikSchellekens
force-pushed
the
joriks/opentracing_e2e
branch
from
7e906bb to
7ab2088
Compare
JorikSchellekens
force-pushed
the
joriks/opentracing_e2e
branch
from
d8b6431 to
22b7e6a
Compare
JorikSchellekens
force-pushed
the
joriks/opentracing_e2e
branch
from
91b07ed to
82d6eb1
Compare
JorikSchellekens
force-pushed
the
joriks/opentracing_e2e
branch
from
efe27f7 to
a68119e
Compare
richvdh
suggested changes
Aug 12, 2019
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
as discussed, can you flatten out one of the layers of dictionaries, and rename the EDU key?
Contributor
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This traces most of the code paths related to e2e stuff. It adds context information into stored edus and tries to link spans across transactions. It traces device_list updates, key queries and key claiming.
This pr is waiting on #5703. I've set the base to joriks/opentracing_utils so that they can be easily compared. I'll switch it over to develop once #5703 lands.