Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add SYNAPSE_REVERSE_PROXY variable for Docker #5206

Closed
wants to merge 1 commit into from

Conversation

LouisMT
Copy link

@LouisMT LouisMT commented May 19, 2019

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file
  • Pull request includes a sign off

Currently, no X-Forwarded-* headers are accepted by Synapse when using the Docker image with generated configuration. So everyone seems to be logged in from the same IP address (the IP address of my reverse proxy).

Add an option to accept these headers.

@LouisMT LouisMT force-pushed the docker-reverse-proxy branch 2 times, most recently from 991a4f4 to 443f64d Compare May 19, 2019 10:59
Signed-off-by: Louis Matthijssen <louis@u5r.nl>
@LouisMT LouisMT force-pushed the docker-reverse-proxy branch from 443f64d to c9d348c Compare May 19, 2019 12:12
@richvdh richvdh requested a review from a team May 22, 2019 11:53
@hawkowl
Copy link
Contributor

hawkowl commented Jun 25, 2019

As per #5518 , we're going to make it so that you would configure this in the same way as any other Synapse instance (by the config file), so not every flag needs an env var + the extra complication of loading it.

@hawkowl hawkowl closed this Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants