This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Batch cache invalidation over replication #4671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently whenever the current state changes in a room invalidate a lot of caches, which cause *a lot* of traffic over replication. Instead, lets batch up all those invalidations and send a single poke down the replication streams. Hopefully this will reduce load on the master process by substantially reducing traffic.
|
This passes the sytests worker config locally (and breaks when I break the cache invalidation) |
Codecov Report
@@ Coverage Diff @@
## develop #4671 +/- ##
===========================================
+ Coverage 75.17% 75.18% +<.01%
===========================================
Files 340 340
Lines 34712 34736 +24
Branches 5677 5680 +3
===========================================
+ Hits 26096 26116 +20
- Misses 7013 7015 +2
- Partials 1603 1605 +2 |
richvdh
reviewed
Feb 19, 2019
| # We probably haven't pulled in the cache in this worker, | ||
| # which is fine. | ||
| pass | ||
| if row.cache_func == _CURRENT_STATE_CACHE_NAME: |
There was a problem hiding this comment.
I'd like to see some words about this (and in general what the 'caches' stream means) documented in docs/tcp_replication.tcp.
There was a problem hiding this comment.
I've added some words. I haven't specified exactly what _CURRENT_STATE_CACHE_NAME means, as I feel like that's just going to quickly get out of date with the code and is probably unnecessary.
richvdh
approved these changes
Feb 19, 2019
|
|
||
| However, there are times when a number of caches need to be invalidated at the | ||
| same time with the same key. To reduce traffic we batch those invalidations into | ||
| a single poke by defining a special cache name that workers understand to mean |
There was a problem hiding this comment.
I don't mind not listing the exact caches, but please can you define the special cache name?
This was referenced Feb 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently whenever the current state changes in a room invalidate a lot
of caches, which cause a lot of traffic over replication. Instead,
lets batch up all those invalidations and send a single poke down
the replication streams.
Hopefully this will reduce load on the master process by substantially
reducing traffic.