Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

set CORS on .well-known URI to unbreak modular #4651

Merged
merged 5 commits into from
Feb 18, 2019

Conversation

ara4n
Copy link
Member

@ara4n ara4n commented Feb 14, 2019

otherwise a riot/web running on foo.riot.im can't query the .well-known on foo.modular.im...

otherwise a riot/web running on foo.riot.im can't query
the .well-known on foo.modular.im...
@richvdh
Copy link
Member

richvdh commented Feb 14, 2019

fixes #4593 I guess?

@ara4n
Copy link
Member Author

ara4n commented Feb 14, 2019

yup

@ara4n ara4n requested a review from a team February 14, 2019 20:47
@richvdh
Copy link
Member

richvdh commented Feb 14, 2019

can has changelog entry pls? lgtm otherwise

@richvdh
Copy link
Member

richvdh commented Feb 14, 2019

oh, except for the bit where all the CI is failing because you haven't imported set_cors_headers

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once you fix the CI

@codecov-io
Copy link

codecov-io commented Feb 18, 2019

Codecov Report

Merging #4651 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4651      +/-   ##
===========================================
- Coverage    75.23%   75.22%   -0.02%     
===========================================
  Files          338      338              
  Lines        34581    34653      +72     
  Branches      5655     5678      +23     
===========================================
+ Hits         26018    26067      +49     
- Misses        6971     6991      +20     
- Partials      1592     1595       +3

@erikjohnston erikjohnston merged commit d08bac4 into develop Feb 18, 2019
@erikjohnston erikjohnston deleted the matthew/well-known-cors branch March 5, 2019 13:52
@n1trux
Copy link

n1trux commented Mar 24, 2019

If you get a 404, the header isn't set, which breaks Riot, for example.

Excerpt from my Chrome network log:

GET https://synapse.example.org/_matrix/identity/api/v1 404
Access to XMLHttpRequest at 'https://synapse.example.org/_matrix/identity/api/v1' from origin 'https://chat.example.org' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

Related: #1595

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants