This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
set CORS on .well-known URI to unbreak modular #4651
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise a riot/web running on foo.riot.im can't query the .well-known on foo.modular.im...
fixes #4593 I guess? |
yup |
can has changelog entry pls? lgtm otherwise |
oh, except for the bit where all the CI is failing because you haven't imported |
richvdh
suggested changes
Feb 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once you fix the CI
Codecov Report
@@ Coverage Diff @@
## develop #4651 +/- ##
===========================================
- Coverage 75.23% 75.22% -0.02%
===========================================
Files 338 338
Lines 34581 34653 +72
Branches 5655 5678 +23
===========================================
+ Hits 26018 26067 +49
- Misses 6971 6991 +20
- Partials 1592 1595 +3 |
richvdh
approved these changes
Feb 18, 2019
If you get a 404, the header isn't set, which breaks Riot, for example. Excerpt from my Chrome network log:
Related: #1595 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise a riot/web running on foo.riot.im can't query the .well-known on foo.modular.im...