This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add top level filters for filtering by room id #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
| if type(definition[key]) != list: | ||
| raise SynapseError(400, "Expected %s to be a list." % key) | ||
| for room_id in definition[key]: | ||
| RoomID.from_string(room_id) |
There was a problem hiding this comment.
Please document the expected side effect here (that it will throw if it is an invalid room ID), else this looks very magical and doesn't intuitively look like it is doing what the docstrings describe.
|
LGTM other than comments |
NegativeMjark
force-pushed
the
markjh/room_filtering
branch
from
84267d5
to
b9b4466
Compare
NegativeMjark
added a commit
that referenced
this pull request
Dec 22, 2015
Add top level filters for filtering by room id Documented by matrix-org/matrix-spec-proposals#246
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented by matrix-org/matrix-spec-proposals#246