Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Port register_new_matrix_user to Python 3 and add tests #4085

Merged
merged 12 commits into from
Oct 26, 2018
Merged

Port register_new_matrix_user to Python 3 and add tests #4085

merged 12 commits into from
Oct 26, 2018

Conversation

hawkowl
Copy link
Contributor

@hawkowl hawkowl commented Oct 24, 2018

No description provided.

@hawkowl hawkowl requested a review from a team October 24, 2018 15:55
@erikjohnston
Copy link
Member

Does it really need to split into a new file?

@hawkowl
Copy link
Contributor Author

hawkowl commented Oct 24, 2018

yes it needs to be in the tree, because scripts/ is not a python package

erikjohnston
erikjohnston reviewed Oct 24, 2018
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise looks alright, I have no idea how this is going to work with the packaging?

@hawkowl hawkowl mentioned this pull request Oct 25, 2018
Closed
@hawkowl hawkowl merged commit 77d70a7 into develop Oct 26, 2018
@hawkowl hawkowl deleted the hawkowl/py3-registermatrix branch October 26, 2018 11:05
@DMRobertson DMRobertson mentioned this pull request Feb 28, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hawkowl @erikjohnston