This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
check isort by travis #3540
Merged
check isort by travis #3540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
krombel
force-pushed
the
enforce_isort
branch
2 times, most recently
from
d3b633e
to
654ec1a
Compare
|
@matrixbot test this please |
richvdh
reviewed
Jul 16, 2018
.travis.yml
Outdated
| @@ -23,6 +23,9 @@ matrix: | |||
| - python: 3.6 | |||
| env: TOX_ENV=py36 | |||
|
|
|||
| - python: 3.6 | |||
| env: TOX_ENV=isort | |||
There was a problem hiding this comment.
can we call this check-isort, to stop me thinking it's going to somehow magically do our isorting?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3463 introduced an
isortconfigurationThis fixes some new appeared isort mistakes and enables Travis to check on each PR.
Signed-Off-By: Matthias Kesler krombel@krombel.de