This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Wrap connections in an N minute timeout to ensure they get reaped correctly #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ara4n
reviewed
Dec 29, 2016
|
|
||
| # Time this connection out if we haven't send a request in the last | ||
| # N minutes | ||
| reactor.callLater(3 * 60, self._time_things_out_maybe) |
There was a problem hiding this comment.
why is it 3 mins here, but 2 mins in the _time_things_out_maybe above?
ara4n
reviewed
Dec 29, 2016
| return _WrappingEndointFac(transport_endpoint(reactor, domain, port, **endpoint_kw_args)) | ||
|
|
||
|
|
||
| class _WrappingEndointFac(object): |
ara4n
reviewed
Dec 29, 2016
| @@ -61,6 +61,11 @@ | |||
| MAX_SHORT_RETRIES = 3 | |||
|
|
|||
|
|
|||
| def test(conn): | |||
ara4n
reviewed
Dec 29, 2016
| reactor.callLater(3 * 60, self._time_things_out_maybe) | ||
| return res | ||
|
|
||
| d.addCallback(update_request_time) |
There was a problem hiding this comment.
why do we do this by both a callback and a reactor.callLater()?
There was a problem hiding this comment.
We schedule a timeout in 3 minutes both before we send the request, and after we received the response.
uhoreg
reviewed
Dec 29, 2016
|
|
||
|
|
||
| class _WrappedConnection(object): | ||
| """Wraps a connection and calls abort on it if it hasn't seen any actio |
There was a problem hiding this comment.
missing "n" in "action". Also, the comment says 5 minutes, but the code says 3 minutes?
The abort() method calls loseConnection() which tries to shutdown the TLS connection cleanly. We now call abortConnection() directly which should promptly close both the TLS connection and the underlying TCP connection. I also added some TODO markers to consider cancelling the old previous timeout rather than checking time.time(). But given how urgently we want to get this code released I'd rather leave the existing code with the duplicate timeouts and the time.time() check.
This was referenced Dec 30, 2016
This was referenced Jan 13, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.